Skip to content

[Metal] Add TVM_METAL_STORAGE_MODE opt-in for correctness at scale (#20157) #20391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zacharywhitley wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −8
Open

[Metal] Add TVM_METAL_STORAGE_MODE opt-in for correctness at scale (#20157) #20391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/backend/metal/runtime/metal_device_api.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
/*!
* \file metal_device_api.mm
*/
#include <cstdlib>
#include <cstring>

#include <tvm/ffi/function.h>
#include <tvm/ffi/reflection/registry.h>
#include <tvm/runtime/logging.h>
Expand Down Expand Up @@ -184,15 +187,14 @@ int GetWarpSize(id<MTLDevice> dev) {
id<MTLBuffer> buf;
AUTORELEASEPOOL {
id<MTLDevice> dev = GetDevice(device);
// GPU memory only
// GPU memory only. Callers can override via TVM_METAL_STORAGE_MODE
// ("shared" or "managed") when Private-mode exposes a driver-level
// correctness issue on their workload — see apache/tvm#20157.
MTLResourceOptions storage_mode = MTLResourceStorageModePrivate;
/*
#if TARGET_OS_IPHONE
storage_mode = MTLResourceStorageModeShared;
#else
storage_mode = MTLResourceStorageModeManaged;
#endif
*/
if (const char* env = std::getenv("TVM_METAL_STORAGE_MODE")) {
if (std::strcmp(env, "shared") == 0) storage_mode = MTLResourceStorageModeShared;
if (std::strcmp(env, "managed") == 0) storage_mode = MTLResourceStorageModeManaged;
}
buf = [dev newBufferWithLength:nbytes options:storage_mode];
TVM_FFI_ICHECK(buf != nil);
};
Expand Down