Skip to content

refactor: remove IDeviceID.isTableModel - #998

Merged
JackieTien97 merged 1 commit into
developfrom
removeIsTableModelMethod
Oct 9, 2026
Merged

JackieTien97 merged 1 commit into
developfrom
removeIsTableModelMethod

Conversation

@shuwenwei

Copy link
Copy Markdown
Member

Summary

  • Remove IDeviceID.isTableModel() and its implementations from PlainDeviceID and StringArrayDeviceID.
  • Replace table-model checks in TsFileIOWriter with tableSchemaMap.containsKey(deviceId.getTableName()) for table point counting and table size accounting.
  • Remove the obsolete IDeviceIDTest.testIsTableModel().

Compatibility

This is a breaking public-interface change for external callers or custom IDeviceID implementations.

Validation

Spotless was run successfully. No compile or test run was requested.

Use the table schema map to identify table-model writes when recording table point counts and sizes.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.52%. Comparing base (617b240) to head (db66409).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #998      +/-   ##
===========================================
- Coverage    64.53%   64.52%   -0.01%     
===========================================
  Files          760      760              
  Lines        53314    53312       -2     
  Branches      8453     8453              
===========================================
- Hits         34404    34402       -2     
  Misses       17258    17258              
  Partials      1652     1652              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackieTien97
JackieTien97 merged commit 1d87fe0 into develop Oct 9, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants