Repository navigation
refactor: remove IDeviceID.isTableModel - #998
Merged
Merged
Conversation
Use the table schema map to identify table-model writes when recording table point counts and sizes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #998 +/- ##
===========================================
- Coverage 64.53% 64.52% -0.01%
===========================================
Files 760 760
Lines 53314 53312 -2
Branches 8453 8453
===========================================
- Hits 34404 34402 -2
Misses 17258 17258
Partials 1652 1652 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shuwenwei
marked this pull request as ready for review
October 9, 2026 10:28
JackieTien97
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IDeviceID.isTableModel()and its implementations fromPlainDeviceIDandStringArrayDeviceID.TsFileIOWriterwithtableSchemaMap.containsKey(deviceId.getTableName())for table point counting and table size accounting.IDeviceIDTest.testIsTableModel().Compatibility
This is a breaking public-interface change for external callers or custom
IDeviceIDimplementations.Validation
Spotless was run successfully. No compile or test run was requested.