Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSV imports currently turn CRLF inside quoted fields into LF because
read_recordstrips each physical line's trailing carriage return before checking quote state. For example,"line\r\nbreak"loses its\rduring import and subsequent CSV round trips.Check quote state before trimming record boundaries so quoted CRLF, LF, and CR remain field data. Open input files in binary mode and keep redirected stdin/stdout in binary mode on Windows to prevent CRT newline translation.
Regression coverage checks mixed line endings, blank continuation lines, escaped quotes, physical line counts, EOF without a final newline, STRING tags, STRING/TEXT fields, and both
write → cat CSV → writeandwrite → export CSV → write.Validation:
The Windows-specific stream setup has not been exercised locally.