Repository navigation
Refactor data type handling with type interfaces - #872
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #872 +/- ##
===========================================
+ Coverage 61.83% 64.10% +2.26%
===========================================
Files 747 757 +10
Lines 51929 52910 +981
Branches 8444 8333 -111
===========================================
+ Hits 32109 33916 +1807
+ Misses 18184 17358 -826
Partials 1636 1636 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
# Conflicts: # java/tsfile/src/main/java/org/apache/tsfile/read/query/dataset/DataSetWithoutTimeGenerator.java
hongzhi-gao
reviewed
Sep 8, 2026
| default: | ||
| throw new UnSupportedDataTypeException(String.valueOf(dataType)); | ||
| } | ||
| Type.fromTsDataType(dataType).init(this); |
Contributor
There was a problem hiding this comment.
DescReadWriteBatchData initializes value lists as ArrayLists but casts them to LinkedList when expanding. This causes a ClassCastException on the 1,025th value.
hongzhi-gao
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TSDataTypeswitch logic across read, write, tools, examples, and testsTesting
./mvnw test -P with-java -pl java/tsfile -am -Dtest=TypeCastTest -Dsurefire.failIfNoSpecifiedTests=false