Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TsFileDataFrame could reject valid tree-model datasets when different devices used the same measurement name with different physical types. For example,
root.a.b.temperature(DOUBLE) androot.c.d.temperature(INT32) failed index construction withincompatible physical type for root.temperature. Without the index, scanning both devices through a shared tree-table column could also decode values using the wrong type.This change makes numeric tree sequences usable through the existing sequence, statistics, and training-window APIs.
Changes
_col_1do not resolve to synthetic path tags.Validation
test_tree_dataset_training.py,test_tsfile_dataset.py,test_dataset_index.py, andtest_dataset_read_options.py.git diff --checkpassed.Coverage includes single-file and multi-file datasets, independent measurement types, full-path reads, statistics, positional and time-range windows, index reload without metadata rescanning, name collisions, and aligned nulls.