Repository navigation
fix(cpp): correct aligned all-null pages and page advancement - #1001
Merged
ColinLeeo merged 4 commits intoOct 10, 2026
Merged
Conversation
ColinLeeo
added a commit
that referenced
this pull request
Oct 10, 2026
* fix: continue aligned queries past all-null pages * fix(cpp): write canonical all-null pages and revert Java changes * test(cpp): refresh CLI goldens for compact all-null pages * test(cpp): focus null-page coverage on canonical format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
C++ serialized aligned all-null value pages with a row count, bitmap, and optional statistics and codec payload instead of the compact empty-page marker used by Java. This could cause queries to miss subsequent non-null values. A normal GORILLA page can also leave a padding byte unread after all values are decoded, preventing the C++ reader from advancing to the next page.
The final diff contains only C++ changes. Java implementations and encoding defaults are unchanged.
Validation
BUILD_TOOLS=ON: 1131 passed, 3 skipped (external fixture configuration unavailable), 10 disabled. The complete CTest run, including CLI and CMake tests, passed with zero failures.git diff --checkpassed.Found while reviewing #968; the issue also reproduces without mixing record and tablet writes.