hrw4u: Fix u4wrh emitting quoted header names in Prism output#13207
Open
Clendenin wants to merge 1 commit into
Open
hrw4u: Fix u4wrh emitting quoted header names in Prism output#13207Clendenin wants to merge 1 commit into
Clendenin wants to merge 1 commit into
Conversation
Header qualifiers that contain only characters legal in the HRW4U IDENT rule were being wrapped in double quotes at emission time, which the grammar rejects on re-parse. Quote a qualifier only when it actually contains characters that require quoting. Adds a parametrized unit test for Validator.unquote_if_ident covering IDENT-safe stripping, space-containing qualifiers, empty strings, and leading-digit rejection, symmetric with the existing needs_quotes and quote_if_needed tests.
Clendenin
force-pushed
the
bugfix/u4wrh-quoted-header
branch
from
57d709a to
c74b482
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Header qualifiers that contain only characters legal in the Prism
IDENTrulewere being wrapped in double quotes at emission time, which the grammar rejects
on re-parse. Quote a qualifier only when it actually contains characters that
require quoting.
Adds a parametrized unit test for
Validator.unquote_if_identcoveringIDENT-safe stripping, space-containing qualifiers, empty strings, and
leading-digit rejection, symmetric with the existing
needs_quotesandquote_if_neededtests.