hrw4u: Fix u4wrh emitting HTTP-section operators into TXN_CLOSE#13204
Open
Clendenin wants to merge 1 commit into
Open
hrw4u: Fix u4wrh emitting HTTP-section operators into TXN_CLOSE#13204Clendenin wants to merge 1 commit into
Clendenin wants to merge 1 commit into
Conversation
u4wrh bypassed section access validation when emitting statements, so operators that declare sections=HTTP_SECTIONS could land inside a generated TXN_CLOSE block. The output then failed re-parse in hrw4u. Validate the operator's declared sections at emit time and surface a clear error when the originating HRW places it in an incompatible hook. Adds a dedicated OPERATOR_MAP reverse-fail fixture for the operator-level path and documents the *.reverse.fail.* fixture naming convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
u4wrh bypassed section access validation when emitting statements, so operators
that declare
sections=HTTP_SECTIONScould land inside a generatedTXN_CLOSEblock. The output then failed re-parse in hrw4u.
This change validates the operator's declared sections at emit time and surfaces
a clear error when the originating HRW places it in an incompatible hook.