Skip to content

THRIFT-6564: Add configurable TLS protocols to Java transports - #4200

Open
HTHou wants to merge 1 commit into
apache:masterfrom
HTHou:THRIFT-6564
Open

HTHou wants to merge 1 commit into
apache:masterfrom
HTHou:THRIFT-6564

Conversation

@HTHou

@HTHou HTHou commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Tracked in THRIFT-6564.

Summary

Add TSSLTransportParameters#setEnabledProtocols(String...) for Java server sockets, blocking client sockets, and nonblocking client engines. Apply the configured list through JSSE during transport creation. Passing null uses the provider defaults.

Document the constructor's protocol argument as the SSLContext algorithm. Report unsupported protocol names during transport creation, close any socket opened before failure, and validate the nonblocking engine before opening its channel.

Downstream projects currently configure the protocol list on the underlying socket. IoTDB #19074 · Accumulo

Validation

  • All 436 Java tests passed locally. The eight new cases cover the three factory paths, defaults and reset, unsupported or empty lists, and socket cleanup. The nonblocking integration case verifies the negotiated protocol against a server offering TLS 1.2 and TLS 1.3.
  • Java spotlessCheck, codespell on the changed files, and git diff --check passed.
  • Repository-wide make style hit existing codespell findings in D and Kotlin test sources during the initial verification.

Generated-by: OpenAI Codex (GPT-6)

@HTHou
HTHou requested review from fishy and jimexist as code owners November 19, 2026 06:57
Copilot AI balanced review requested due to automatic review settings November 19, 2026 06:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@mergeable mergeable Bot added the java Pull requests that update Java code label Nov 19, 2026
Client: java

Apply an explicitly configured protocol list to Java SSL server sockets,
blocking client sockets, and nonblocking client engines. Release a
listener or blocking socket if configuration fails and configure the
client engine before opening its channel.

Generated-by: OpenAI Codex (GPT-6)
Copilot AI balanced review requested due to automatic review settings November 19, 2026 07:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@HTHou HTHou changed the title THRIFT-6564: Add configurable TLS protocols to Java server sockets THRIFT-6564: Add configurable TLS protocols to Java transports Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants