Repository navigation
refactor(frontend): remove dead ngx-drop-box class - #9142
Open
aglinxinyuan wants to merge 1 commit into
Open
aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Removes the unused .ngx-drop-box class and selector from files-uploader.component.html and files-uploader.component.scss. Because <ng-template> renders no DOM element, the class was never attached to any element in the DOM.
github-actions
Bot
added
refactor
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9142 +/- ##
==========================================
Coverage 92.33% 92.34%
Complexity 5045 5045
==========================================
Files 1261 1266 +5
Lines 54120 54525 +405
Branches 6768 6885 +117
==========================================
+ Hits 49973 50349 +376
- Misses 2486 2496 +10
- Partials 1661 1680 +19
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes the
.ngx-drop-boxrule infiles-uploader.component.scssand theclassattribute that sets it on an<ng-template>. +1/-8 lines. There is no behaviour change. The class sits on an<ng-template>, which Angular never renders as a DOM element, so the rule can never match.<ng-template>renders no element)It has never had an effect.
Any related issues, documentation, discussions?
Closes #9141.
How was this PR tested?
Stylesheet-only deletion.
yarn format:ciandnpx ng buildpass fromfrontend/.To re-check:
git grep -n "ngx-drop-box" -- frontend/srcreturns no hits.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Antigravity (Claude Opus 5.5)