Repository navigation
Conversation
BreakpointConditionInputComponent's left() and top() have never had a production caller: since apache#2953 the popup is positioned by ngOnChanges through the template's [ngStyle] binding. Remove both methods and the spec cases that only exercised them.
Contributor
Automated Reviewer SuggestionsBased on the
|
github-actions
Bot
added
refactor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9113 +/- ##
============================================
+ Coverage 92.34% 92.58% +0.24%
+ Complexity 5046 5029 -17
============================================
Files 1261 1260 -1
Lines 54117 53705 -412
Branches 6767 6697 -70
============================================
- Hits 49973 49723 -250
+ Misses 2485 2324 -161
+ Partials 1659 1658 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…t-input-dead-positioning
kunwp1
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes
BreakpointConditionInputComponent.left()andtop(), two positioning methods that nothing in production calls. −66 lines. There is no behaviour change.The popup is positioned by
ngOnChanges, which computestopPositionandleftPositionfor the template's[ngStyle]="{ top: topPosition, left: leftPosition }"binding. The template never callsleft()ortop(). The component's one host,code-debugger, binds only its inputs and output, and the two parentViewChildfields that reference the component are never read. Every import is still used.The spec loses the five cases that only exercised the two methods. Its coverage of the surviving positioning (
ngOnChanges,topPosition,leftPosition) stays.History
[ngStyle]positioning that is actually usedThey have been unused for the two years since they were added.
Any related issues, documentation, discussions?
Closes #9110
How was this PR tested?
No new tests. The surviving positioning keeps its cases.
From
frontend/:npx ng test --watch=false --include='**/breakpoint-condition-input.component.spec.ts' --include='**/code-debugger.component.spec.ts' --include='**/code-editor.component.spec.ts': 3 files, 126 tests, all pass. The last two specs cover the component's host and the code editor that declares it.npx tsc --noEmit -p src/tsconfig.app.jsonand-p src/tsconfig.spec.json: clean.yarn format:ci: clean.npx ng build: success.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code