Repository navigation
refactor(frontend): remove unused AiAnalystService injection - #9112
Merged
kunwp1 merged 2 commits intoOct 25, 2026
Merged
Conversation
apache#2816 injected WorkflowActionService into AiAnalystService as a public field that nothing has ever read. Drop the parameter and its import, and the spec's empty stub that existed only for it.
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9112 +/- ##
============================================
- Coverage 92.33% 92.33% -0.01%
Complexity 5045 5045
============================================
Files 1261 1261
Lines 54120 54118 -2
Branches 6768 6768
============================================
- Hits 49974 49972 -2
Misses 2486 2486
Partials 1660 1660
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…t-unused-injection
kunwp1
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes
AiAnalystService's unusedworkflowActionServiceconstructor injection and its import. +2/−9 lines. There is no behaviour change.The field is public, but nothing reads it: not the service, its one consumer
ReportGenerationService(which uses its ownWorkflowActionService), any template or any spec. Nothing builds the service by hand; Angular DI creates it, andWorkflowActionServiceis provided in root, so dropping the parameter is safe. The spec drops its emptyWorkflowActionServicestub, whose comment already said it existed only for this unused dependency.History
It has been unused for the two years since it was added.
Any related issues, documentation, discussions?
Closes #9109
How was this PR tested?
No new tests.
From
frontend/:npx ng test --watch=false --include='**/ai-analyst.service.spec.ts' --include='**/report-generation.service.spec.ts' --include='**/menu.component.spec.ts': 3 files, 178 tests, all pass. The last two specs cover the service's consumer.npx tsc --noEmit -p src/tsconfig.app.jsonand-p src/tsconfig.spec.json: clean.yarn format:ci: clean.npx ng build: success.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code