Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5377 +/- ##
============================================
- Coverage 92.60% 92.52% -0.08%
- Complexity 5043 5061 +18
============================================
Files 1252 1261 +9
Lines 53587 53963 +376
Branches 6673 6744 +71
============================================
+ Hits 49623 49930 +307
- Misses 2315 2353 +38
- Partials 1649 1680 +31
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 359 | 0.219 | 25,463/39,456/39,456 us | 🔴 +17.1% / 🔴 +168.9% |
| 🔴 | bs=100 sw=10 sl=64 | 786 | 0.48 | 126,112/142,588/142,588 us | 🔴 +5.9% / 🔴 +39.3% |
| 🔴 | bs=1000 sw=10 sl=64 | 895 | 0.546 | 1,116,208/1,215,976/1,215,976 us | 🔴 +8.4% / 🔴 +23.5% |
Baseline details
Latest main be65bf8 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 359 tuples/sec | 407 tuples/sec | 866.99 tuples/sec | -11.8% | -58.6% |
| bs=10 sw=10 sl=64 | MB/s | 0.219 MB/s | 0.248 MB/s | 0.529 MB/s | -11.7% | -58.6% |
| bs=10 sw=10 sl=64 | p50 | 25,463 us | 22,238 us | 11,989 us | +14.5% | +112.4% |
| bs=10 sw=10 sl=64 | p95 | 39,456 us | 33,684 us | 14,672 us | +17.1% | +168.9% |
| bs=10 sw=10 sl=64 | p99 | 39,456 us | 33,684 us | 17,906 us | +17.1% | +120.4% |
| bs=100 sw=10 sl=64 | throughput | 786 tuples/sec | 827 tuples/sec | 1,111 tuples/sec | -5.0% | -29.3% |
| bs=100 sw=10 sl=64 | MB/s | 0.48 MB/s | 0.505 MB/s | 0.678 MB/s | -5.0% | -29.2% |
| bs=100 sw=10 sl=64 | p50 | 126,112 us | 119,115 us | 95,405 us | +5.9% | +32.2% |
| bs=100 sw=10 sl=64 | p95 | 142,588 us | 146,009 us | 102,332 us | -2.3% | +39.3% |
| bs=100 sw=10 sl=64 | p99 | 142,588 us | 146,009 us | 115,219 us | -2.3% | +23.8% |
| bs=1000 sw=10 sl=64 | throughput | 895 tuples/sec | 912 tuples/sec | 1,141 tuples/sec | -1.9% | -21.5% |
| bs=1000 sw=10 sl=64 | MB/s | 0.546 MB/s | 0.557 MB/s | 0.696 MB/s | -2.0% | -21.6% |
| bs=1000 sw=10 sl=64 | p50 | 1,116,208 us | 1,099,146 us | 938,794 us | +1.6% | +18.9% |
| bs=1000 sw=10 sl=64 | p95 | 1,215,976 us | 1,121,883 us | 984,521 us | +8.4% | +23.5% |
| bs=1000 sw=10 sl=64 | p99 | 1,215,976 us | 1,121,883 us | 1,008,827 us | +8.4% | +20.5% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,556.57,200,128000,359,0.219,25462.92,39456.16,39456.16
1,100,10,64,20,2545.78,2000,1280000,786,0.480,126111.86,142587.79,142587.79
2,1000,10,64,20,22349.80,20000,12800000,895,0.546,1116208.19,1215976.00,1215976.00
Automated Reviewer SuggestionsBased on the
|
zuozhiw
left a comment
There was a problem hiding this comment.
left some comments, please fix them, I clicked "approve" so that you can feel free to merge this PR after fixing these commments, because this is a env setup PR, please make sure to carefully make AI actually test these configurations and make sure they work
apart from that I have some reservations about ebpf, it's more sensitive than application level log/traces/metrics. Furthermore, ebpf is normally used for very advanced diagnostics and profiling, and seems a bit heavy for our use case. But again feel free to try it and see if we see it being useful.
Also one more missing piece of the telemetry data is host level metrics, e.g. cpu, memory being the most important ones, please check how we can collect them, e.g. I think otel has some host metrics receiver, please check that, also check if docker / k8s expose metrics and how we can get them.
Another missing piece is database related metrics. E.g. database load, it would also be nice to consider them, but maybe in future PRs.
eea0a7a to
3523acd
Compare
7dc58ab to
45448ad
Compare
|
@parshimers @sshiv012 @zuozhiw this PR is updated for the scope-down: the bundled stack now adds Grafana (dashboards) and Loki (logs) over the exported telemetry, alongside VictoriaMetrics, Jaeger, and Parca, plus a README covering how to point an external Grafana or OpenSearch at the same endpoints. Grafana and Loki are AGPLv3 optional operator-run components, not bundled in any release artifact. Could you re-review when you get a chance? Thanks. |
There was a problem hiding this comment.
Please address the deployment issues below before merging. Enabling observability currently hits Helm rendering errors; a fresh Compose deployment also cannot start VictoriaMetrics, and the native local-dev launcher does not expose the collector ports. These prevent the configured stack from receiving or storing telemetry. The CU environment and Loki retention comments cover additional gaps once the stack is running.
Please add focused regression checks where practical:
- Render Helm with observability enabled and disabled.
- Check the environment variables built for CU pods.
- Render the exact Compose files used by local-dev and check the collector port mappings.
- Check VictoriaMetrics startup with a fresh volume.
- Check the generated Loki retention settings.
The operational dashboards and alerts are a follow-up request and do not all need to land in this PR.
f18438a to
ca4c781
Compare
zuozhiw
left a comment
There was a problem hiding this comment.
fix the merge conflict then good to merge
…9070) ### What changes were proposed in this PR? Removes dead code from `UserDatasetVersionCreatorComponent`. **+3/−19 lines.** There is no behaviour change. - **`isCreateButtonDisabled`:** nothing ever writes it, so it is always `false`. The create button's `[disabled]="isCreateButtonDisabled || isCreating"` becomes `[disabled]="isCreating"`, which evaluates identically. - **The `formBuilder` injection:** nothing reads it. `FormBuilder` is provided in root, so dropping the parameter (and its import) changes nothing. - **`.file-uploader` and `.toggle-item .help-text`:** the component uses emulated encapsulation and no element in its template has either class. The `files-uploader` child renders its own `.file-uploader`, which this stylesheet can't reach. ### History | | | | --- | --- | | **Introduced by** | apache#2413 (2024-02-27), "Introduce Dataset GUI": `isCreateButtonDisabled`, `formBuilder` and `.file-uploader`. apache#3663 (2025-08-17), "feat: adding option to allow owner to disallow downloading datasets": `.help-text` | | **Usage removed by** | apache#3296 (2025-03-11), "Add FileService as a standalone microservice, LakeFS+S3 as dataset storage", removed the `<div class="file-uploader">` wrapper. `isCreateButtonDisabled`, `formBuilder` and `.help-text` were **never used** | `isCreateButtonDisabled` and `formBuilder` have been unused for the two and a half years since they were added. ### Any related issues, documentation, discussions? Closes apache#9067 ### How was this PR tested? No new tests. The component spec's create-button cases still cover the `[disabled]` binding through `isCreating`. From `frontend/`: - `npx ng test --watch=false --include='**/user-dataset-version-creator.component.spec.ts' --include='**/user-dataset.component.spec.ts' --include='**/result-exportation.component.spec.ts'`: 3 files, 105 tests, all pass. The last two specs cover the component's two modal hosts. - `yarn format:ci`: clean. - `npx ng build`: success. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
ca4c781 to
2467a07
Compare
What changes were proposed in this PR?
Provides the local deployment wiring that receives and stores telemetry. Off by default and isolated from the application services.
docker-composestack and the Kubernetes Helm chart..envanddocker-composeas opt-in compose profiles;COMPOSE_PROFILESis empty by default, sodocker compose upruns only core Texera.Any related issues, documentation, or discussions?
Closes: #5369
Part of #4070. Stacked on #5376.
How was this PR tested?
ObservabilityComposeSpec,ParcaConfigSpec); 24 tests pass.sbt scalafmtCheckAllpasses; the build runs in this PR's CI.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF policy.