Skip to content

fix: Duplicate JSONToMap in JSONUtils and JSONUtil #4977

Open
Ma77Ball wants to merge 3 commits intoapache:mainfrom
Ma77Ball:fix/json_utils_duplicates
Open

fix: Duplicate JSONToMap in JSONUtils and JSONUtil #4977
Ma77Ball wants to merge 3 commits intoapache:mainfrom
Ma77Ball:fix/json_utils_duplicates

Conversation

@Ma77Ball
Copy link
Copy Markdown
Contributor

@Ma77Ball Ma77Ball commented May 7, 2026

What changes were proposed in this PR?

JSONToMap was duplicated byte-for-byte in JSONUtils.scala (workflow-core) and JSONUtil.scala (workflow-operator). Deleted the workflow-operator copy and updated JSONLScanSourceOpExec to import from JSONUtils.

Any related issues, documentation, discussions?

closes: #4813

How was this PR tested?

Existing JSONLScanSourceOpExec tests. No behavior change

Was this PR authored or co-authored using generative AI tooling?

Co-authored by Claude Opus 4.7 in compliance with ASF

@aglinxinyuan aglinxinyuan enabled auto-merge (squash) May 7, 2026 08:04
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.14%. Comparing base (b9bbf0d) to head (6f4fea1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4977      +/-   ##
============================================
- Coverage     42.71%   42.14%   -0.58%     
  Complexity     2185     2185              
============================================
  Files          1032      980      -52     
  Lines         38161    36261    -1900     
  Branches       4006     3787     -219     
============================================
- Hits          16301    15282    -1019     
+ Misses        20840    20045     -795     
+ Partials       1020      934      -86     
Flag Coverage Δ *Carryforward flag
access-control-service 39.53% <ø> (ø)
agent-service 33.72% <ø> (ø) Carriedforward from ea6607e
amber 43.21% <ø> (+0.03%) ⬆️
computing-unit-managing-service 0.00% <ø> (ø)
config-service 0.00% <ø> (ø)
file-service 32.18% <ø> (ø)
frontend 30.52% <ø> (-2.57%) ⬇️ Carriedforward from ea6607e
python 87.57% <ø> (-1.33%) ⬇️ Carriedforward from ea6607e
workflow-compiling-service 47.72% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSONUtil duplicates JSONUtils.JSONToMap byte-for-byte

4 participants