Conversation
d03d87b to
3d56ad9
Compare
|
This PR is supposed to extract unrelated changes from #4166. |
There was a problem hiding this comment.
are these actually different?
There was a problem hiding this comment.
They have only been formatted, hence why they look the same. I was considering not touching them, because with a proper linting they might be formatted anyway again.
There was a problem hiding this comment.
not toally sure what these are?
There was a problem hiding this comment.
These are SVG symbols from Material Symbols that replace the library which previously was providing these and is not updated anymore. See Implicit dependency on material-icons-core removed for more information.
The XML format comes from Android and grants maximum compatibility. See Compose Multiplatform Resources Usage / Images for more details.
Alternatively, we would have to include the SVG assets like demonstrated here. So I chose the XML format instead.
epugh
left a comment
There was a problem hiding this comment.
LGTM. Took a sec to understand the .xml
Description
With the pass of time multiple dependencies require update, upgrade and alignment.
Solution
This PR updates the dependencies used in the New UI module including Kotlin to the latest version. Due to the migration to newer version, some UI modules changed their structure and require manual migration, like integration of icons for example.
This PR also enables Compose hot reload so that the desktop client can be developed with the hot-reload feature.
Dependency bump includes:
Tests
The new UI was tested via manual build and execution (since it is just dependency updates).
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.Additional Notes
The material symbols included come with an Apache License 2.0, which is included directly to the file like any other file.