Skip to content

[ISSUE #7599] Document the Apollo deprecation and plugin-store migration contract - #7627

Merged
Aias00 merged 1 commit into
apache:masterfrom
yangjj-iso:feat/7599-apollo-deprecation
Oct 15, 2026
Merged

Aias00 merged 1 commit into
apache:masterfrom
yangjj-iso:feat/7599-apollo-deprecation

Conversation

@yangjj-iso

@yangjj-iso yangjj-iso commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Propose the advance Apollo deprecation notice and migration contract for #7599 before any main-repository removal.

Apollo remains supported and all four in-tree modules, current dependencies and runtime behavior stay available for the release carrying this notice. Add a README/registry dependency pointer, an Unreleased deprecation note and docs/plugin-store-apollo.md covering external artifacts, enablement, existing configuration/key layout, SPI loading, retained ApolloPathConstants, one-owner publication, upgrade and rollback.

The guide explicitly requires a dev-list decision, a released core deprecation cycle, passing receiving parity tests, compatible external publication before a later cutover, and an announced rollback window. It does not invent a removal release or claim that PR creation/documentation merge completes those gates.

Validation: the complete 209-module reactor passed ./mvnw -B -ntp validate; git diff --check passed. This is documentation only, so no new behavioral tests are added.

Companion receiving extension: apache/shenyu-plugin-store#28. Later removal draft: #7628.

This is the first stage; the removal draft must wait for the release gates above. Please review the deprecation/publication contract before the notice is released. #7599 remains open until the coordinated cutover is completed.

@Aias00 Aias00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: APPROVE

This is a clear, accurate deprecation notice and migration contract that is fully consistent with #7599 and the master tracking issue #7306.

Strengths:

  • The staged table (Agreement → Deprecation release → Receiving parity → Publication → Later core release) correctly makes the in-tree modules stay available for the deprecation release and defers actual removal to a later, explicitly-gated core release. The line "Do not treat creating PRs, merging documentation, or producing local snapshot JARs as completing the dev-list decision…" is exactly the guardrail this kind of externalization needs.
  • The SPI contract (ShenyuInstanceRegisterRepositoryFactory.loadRepository("apollo") resolving the external resource without a core change) and the retained ApolloPathConstants shim are the right compatibility promises.
  • The stored-key table and upgrade/rollback section are precise and operator-actionable.

Nits (non-blocking):

  • Consider cross-linking this doc from the plugin-store index/overview so operators landing on docs/ find it alongside plugin-store-consul.md / plugin-store-hystrix.md.
  • The example coordinates "store 2.7.1-SNAPSHOT against core 2.7.2-SNAPSHOT" are clearly called out as development coordinates, which is good — just make sure the final published doc replaces them with a real compatibility matrix.

Approving as documentation-only and consistent with the issue I filed (#7599).

@Aias00
Aias00 merged commit 6e4cb4c into apache:master Oct 15, 2026
21 checks passed
@Aias00 Aias00 added this to the 2.7.2 milestone Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants