Repository navigation
[ISSUE #7599] Document the Apollo deprecation and plugin-store migration contract - #7627
Merged
Merged
Conversation
This was referenced Oct 14, 2026
Aias00
approved these changes
Oct 15, 2026
Aias00
left a comment
Contributor
There was a problem hiding this comment.
Review: APPROVE
This is a clear, accurate deprecation notice and migration contract that is fully consistent with #7599 and the master tracking issue #7306.
Strengths:
- The staged table (Agreement → Deprecation release → Receiving parity → Publication → Later core release) correctly makes the in-tree modules stay available for the deprecation release and defers actual removal to a later, explicitly-gated core release. The line "Do not treat creating PRs, merging documentation, or producing local snapshot JARs as completing the dev-list decision…" is exactly the guardrail this kind of externalization needs.
- The SPI contract (
ShenyuInstanceRegisterRepositoryFactory.loadRepository("apollo")resolving the external resource without a core change) and the retainedApolloPathConstantsshim are the right compatibility promises. - The stored-key table and upgrade/rollback section are precise and operator-actionable.
Nits (non-blocking):
- Consider cross-linking this doc from the plugin-store index/overview so operators landing on
docs/find it alongsideplugin-store-consul.md/plugin-store-hystrix.md. - The example coordinates "store 2.7.1-SNAPSHOT against core 2.7.2-SNAPSHOT" are clearly called out as development coordinates, which is good — just make sure the final published doc replaces them with a real compatibility matrix.
Approving as documentation-only and consistent with the issue I filed (#7599).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propose the advance Apollo deprecation notice and migration contract for #7599 before any main-repository removal.
Apollo remains supported and all four in-tree modules, current dependencies and runtime behavior stay available for the release carrying this notice. Add a README/registry dependency pointer, an Unreleased deprecation note and
docs/plugin-store-apollo.mdcovering external artifacts, enablement, existing configuration/key layout, SPI loading, retainedApolloPathConstants, one-owner publication, upgrade and rollback.The guide explicitly requires a dev-list decision, a released core deprecation cycle, passing receiving parity tests, compatible external publication before a later cutover, and an announced rollback window. It does not invent a removal release or claim that PR creation/documentation merge completes those gates.
Validation: the complete 209-module reactor passed
./mvnw -B -ntp validate;git diff --checkpassed. This is documentation only, so no new behavioral tests are added.Companion receiving extension: apache/shenyu-plugin-store#28. Later removal draft: #7628.
This is the first stage; the removal draft must wait for the release gates above. Please review the deprecation/publication contract before the notice is released. #7599 remains open until the coordinated cutover is completed.