Fixes #6775: Guard ExtensionLoader joins during concurrent initialization - #7140
Open
BobSong-dev wants to merge 4 commits into
Open
BobSong-dev wants to merge 4 commits into
BobSong-dev wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6775
Background
ExtensionLoader#getJoins() treated cachedInstances.size() matching the number of extension classes as proof that every cached Holder was ready. However, getJoin() publishes a new Holder before populating its order and value. A concurrent getJoins() call could therefore sort or return an incompletely initialized holder, causing an NPE or a null element.
Changes
Verification