Skip to content

fix(logging): flush buffered logs on close - #7127

Open
dengliming wants to merge 2 commits into
apache:masterfrom
dengliming:fix-6763-drain-log-collector-on-close
Open

dengliming wants to merge 2 commits into
apache:masterfrom
dengliming:fix-6763-drain-log-collector-on-close

Conversation

@dengliming

Copy link
Copy Markdown
Member

Summary

  • stop accepting new log entries once collector shutdown begins
  • drain default and per-selector queues in bounded final batches before closing the client
  • add regression coverage for single-client ordering and all multi-client buffers

Testing

  • mvn -q -pl shenyu-plugin/shenyu-plugin-logging/shenyu-plugin-logging-common -am -DskipTests=false -Dcheckstyle.skip=false -Dtest=AbstractLogCollectorTest -DfailIfNoTests=false test

Fixes #6763

@Aias00 Aias00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as PMC (Aias00). Reviewed the diff — small, well-scoped fix with regression tests; mergeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] AbstractLogCollector.close() drops all buffered logs on shutdown

2 participants