Skip to content

fix(sentinel): serialize global rule updates - #7125

Open
dengliming wants to merge 4 commits into
apache:masterfrom
dengliming:fix-6759-serialize-sentinel-rule-updates
Open

dengliming wants to merge 4 commits into
apache:masterfrom
dengliming:fix-6759-serialize-sentinel-rule-updates

Conversation

@dengliming

Copy link
Copy Markdown
Member

Summary

  • serialize Sentinel flow and degrade rule read-modify-write sequences across handler instances
  • include cache updates and removals in the same critical section
  • add concurrent regression coverage to ensure no global rules are lost

Testing

  • mvn -q -pl shenyu-plugin/shenyu-plugin-fault-tolerance/shenyu-plugin-sentinel -am -DskipTests=false -Dcheckstyle.skip=false -Dtest=SentinelRuleHandleTest -DfailIfNoTests=false test

Fixes #6759

@Aias00 Aias00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as PMC (Aias00). Reviewed the diff — small, well-scoped fix with regression tests; mergeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Sentinel rule handler read-modify-writes the global rule list non-atomically (lost updates)

2 participants