Skip to content

fix(ai): evict transformer clients by rule id - #7121

Open
dengliming wants to merge 3 commits into
apache:masterfrom
dengliming:fix-6755-transformer-client-cache-key
Open

dengliming wants to merge 3 commits into
apache:masterfrom
dengliming:fix-6755-transformer-client-cache-key

Conversation

@dengliming

Copy link
Copy Markdown
Member

Summary

  • evict request-transformer clients with the same rule ID used for insertion
  • apply the same cache-key fix to response-transformer clients
  • remove handle parsing from client cleanup and add cache eviction regression coverage

Testing

  • mvn -q -pl shenyu-plugin/shenyu-plugin-ai/shenyu-plugin-ai-request-transformer,shenyu-plugin/shenyu-plugin-ai/shenyu-plugin-ai-response-transformer -am -DskipTests=false -Dcheckstyle.skip=false -Dtest=AiRequestTransformerPluginHandlerTest,AiResponseTransformerPluginHandlerTest -DfailIfNoTests=false test

Fixes #6755

@Aias00 Aias00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as PMC (Aias00). Reviewed the diff — small, well-scoped fix with regression tests; mergeable. Note: the only failing CI checks (shenyu-integrated-test-*/e2e-case-logging-rocketmq) are failing cluster-wide across unrelated PRs (shared CI-env issue), not caused by this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] removeRule destroys the wrong cache key, leaking stale ChatClients

2 participants