Skip to content

fix(mcp): encode request path values - #7118

Open
dengliming wants to merge 1 commit into
apache:masterfrom
dengliming:fix-6751-encode-request-path-values
Open

dengliming wants to merge 1 commit into
apache:masterfrom
dengliming:fix-6751-encode-request-path-values

Conversation

@dengliming

Copy link
Copy Markdown
Member

Summary

  • encode substituted path segments and query parameter values
  • preserve reserved characters instead of truncating values at question marks
  • avoid treating arbitrary values containing a question mark as complete URLs

Testing

  • mvn -q -pl shenyu-plugin/shenyu-plugin-mcp-server -am -DskipTests=false -Dcheckstyle.skip=false -Dtest=RequestConfigHelperTest -DfailIfNoTests=false test

Fixes #6751

@Aias00 Aias00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as PMC (Aias00). Reviewed the diff — small, well-scoped fix with regression tests; mergeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] RequestConfigHelper.buildPath does not URL-encode path/query values

2 participants