fix: add transactional boundaries to metadata batch operations (#6708) - #7048
Open
juicewcode wants to merge 3 commits into
Open
juicewcode wants to merge 3 commits into
juicewcode wants to merge 3 commits into
Conversation
…e#6708) Add @transactional(rollbackFor = Exception.class) to deleteByIdsAndNamespaceId and enabledByIdsAndNamespaceId in MetaDataServiceImpl. Extend MetaDataServiceTest to verify that enable events are not published when the database update affects zero rows, and are published after a successful update.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Mixed-namespace enable requests can still update metadata outside the requested namespace.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds transactional boundaries to metadata batch delete/enable operations and verifies enable-event behavior.
Changes:
- Annotates both service methods with rollback-enabled transactions.
- Tests zero-update suppression and successful enable event publication.
File summaries
| File | Description |
|---|---|
MetaDataServiceImpl.java |
Adds transactional annotations to batch operations. |
MetaDataServiceTest.java |
Adds enable event-path coverage. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
|
|
||
| @Override | ||
| @Transactional(rollbackFor = Exception.class) |
Aias00
approved these changes
Sep 19, 2026
Aias00
left a comment
Aias00
left a comment
Contributor
There was a problem hiding this comment.
Approved as PMC (Aias00). Small, well-scoped fix with regression tests; green CI, mergeable. Reviewed the diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6708
Summary
MetaDataServiceImpl.deleteByIdsAndNamespaceId.MetaDataServiceImpl.enabledByIdsAndNamespaceId.Test
ID_NOT_EXISTpath.Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.