Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The shared snapshot dependency prevents clean standalone example builds unless the artifact or build/documentation override is provided.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 1
- Review effort level: Lite
| <maven-checkstyle-plugin.version>3.4.0</maven-checkstyle-plugin.version> | ||
| <swagger.version>2.6.0</swagger.version> | ||
| <shenyu.client.java.version>2.7.0.3</shenyu.client.java.version> | ||
| <shenyu.client.java.version>2.7.2-SNAPSHOT</shenyu.client.java.version> |
|
Should I revert the version in the shenyu-client parent POM to 2.7.0.3 while allowing shenyu-examples-mcp to use 2.7.2-snapshot separately? |
|
@hengyuss Thanks for the explanation. I understand the motivation for aligning the client versions to avoid registration issues when multiple My concern is that changing the shared Would it be possible to keep the parent version on the released artifact and apply a more scoped override for |
Aias00
left a comment
There was a problem hiding this comment.
Approved as PMC (Aias00). Coherent fix with regression tests; green CI, mergeable. Reviewed the diff.
|
I think update the related build/documentation is a good choice and I will do it |
Fixes: #7032
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.