Skip to content

fix: make shenyu-examples-mcp work normally - #7033

Open
hengyuss wants to merge 8 commits into
apache:masterfrom
hengyuss:fix/shenyu_examples_mcp_can_not_find_healthy_upstream
Open

hengyuss wants to merge 8 commits into
apache:masterfrom
hengyuss:fix/shenyu_examples_mcp_can_not_find_healthy_upstream

Conversation

@hengyuss

@hengyuss hengyuss commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Fixes: #7032

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@dengliming
dengliming requested a balanced review from Copilot September 18, 2026 07:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The shared snapshot dependency prevents clean standalone example builds unless the artifact or build/documentation override is provided.

Get a fresh assessment by requesting another Copilot review.

Review details
  • Files reviewed: 12/12 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread shenyu-examples/pom.xml
<maven-checkstyle-plugin.version>3.4.0</maven-checkstyle-plugin.version>
<swagger.version>2.6.0</swagger.version>
<shenyu.client.java.version>2.7.0.3</shenyu.client.java.version>
<shenyu.client.java.version>2.7.2-SNAPSHOT</shenyu.client.java.version>
@hengyuss

Copy link
Copy Markdown
Contributor Author

Should I revert the version in the shenyu-client parent POM to 2.7.0.3 while allowing shenyu-examples-mcp to use 2.7.2-snapshot separately?
If examples depend on multiple shenyu-clients, issues may arise where upstream services fail to register successfully. So I change ther the version in the shenyu-client parent POM to 2.7.2-snapshot for the fix can apply.
@dengliming

@dengliming

Copy link
Copy Markdown
Member

@hengyuss Thanks for the explanation. I understand the motivation for aligning the client versions to avoid registration issues when multiple shenyu-client versions are involved.

My concern is that changing the shared shenyu.client.java.version to 2.7.2-SNAPSHOT affects all examples, not just shenyu-examples-mcp, and introduces a dependency on an unreleased snapshot version for clean standalone builds. Since the examples README still points to the published 2.7.0.3 artifacts, this could make the repository harder to build for other contributors.

Would it be possible to keep the parent version on the released artifact and apply a more scoped override for shenyu-examples-mcp, or update the related build/documentation together if the whole examples module now requires the snapshot?

Aias00
Aias00 previously approved these changes Sep 19, 2026

@Aias00 Aias00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as PMC (Aias00). Coherent fix with regression tests; green CI, mergeable. Reviewed the diff.

@hengyuss

Copy link
Copy Markdown
Contributor Author

I think update the related build/documentation is a good choice and I will do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] shenyu-examples-mcp can't find healthy upstream

4 participants