Conversation
Aias00
left a comment
There was a problem hiding this comment.
Reviewed the changes and did not find blocking issues.
|
This is a good step forward, but I think we still need an explicit readiness check before sending the request. Right now we start the consumer and immediately issue the HTTP call, then wait for the log to appear. In CI, the flaky part seems to be that the route/logging path may not be fully ready yet when that request is sent, so we can still miss the log and time out even though RocketMQ itself is healthy. Could we split this into two phases?
That would make the test assert “logging works after the system is ready” rather than depending on startup timing. |
|
Heads-up (PMC Aias00): your PR's CI failures are in shared infrastructure checks ( |
Fixes #6817.
Changes
Verification
mvn -f shenyu-e2e/pom.xml -pl :shenyu-e2e-case-logging-rocketmq -am test-compile.@Aias00, could you please help review this PR? Thank you!