Skip to content

chore: route issue and PR events to the notifications list - #38

Merged
Aias00 merged 1 commit into
apache:masterfrom
cloudbase-ai:fix/route-issue-pr-notifications-20261119
Nov 19, 2026
Merged

Aias00 merged 1 commit into
apache:masterfrom
cloudbase-ai:fix/route-issue-pr-notifications-20261119

Conversation

@cloudbase-ai

Copy link
Copy Markdown
Contributor

Route all issue/PR event categories explicitly to notifications@shenyu.apache.org.

The existing .asf.yaml already configures the general issue and PR recipients, while GitBox's public legacy/default scheme page still lists dev@shenyu.apache.org. This change adds explicit recipients for issue status changes, issue comments, PR status changes and PR comments/reviews, using ASF's documented notification hierarchy, and causes the default-branch notification configuration to be resynchronized when merged.

Only .asf.yaml is changed. Existing general recipients, commit notifications and all GitHub settings are preserved. The legacy asf.yaml file is left alone.

Validation: YAML parsed successfully; all added keys are accepted by the official ASF notification implementation; semantic comparison confirms only the four event-specific targets were added. Real email delivery has not been tested, and the GitBox page describes legacy defaults rather than proving which override is active. No synthetic issue/email was sent to validate delivery.

References:

Signed-off-by: cloudbase-ai <22498243+cloudbase-ai@users.noreply.github.com>

@Aias00 Aias00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated the exact configuration-only head. The diff adds the four documented event-specific notification recipients (issue status/comments and PR status/comments/reviews), all targeting notifications@shenyu.apache.org. YAML parsing and accepted-key checks against the official ASF notifications implementation pass. Existing general recipients, commit notification target and GitHub metadata are unchanged.

The public GitBox scheme page shows legacy defaults pointing at dev@; it is not proof of which override is active. This approval validates the configuration and requests its default-branch application, not a claim that email delivery has already been observed. The existing Java build is unrelated to notification routing and no required branch CI gate is configured; no CI rule was changed or bypassed.

@Aias00
Aias00 merged commit cb0cf39 into apache:master Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants