Repository navigation
[ISSUE #7454] Restore RabbitMQ selector clients after global fallback - #33
Open
yangjj-iso wants to merge 2 commits into
Open
yangjj-iso wants to merge 2 commits into
yangjj-iso wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching a RabbitMQ logging Selector from custom configuration A to global settings and then back to the identical A currently leaves it using the global client. Client invalidation retains the saved configuration, so the equality check suppresses reconstruction.
Remove the saved Selector configuration when invalidating its custom client. Add regression controls for A → global → identical A, unchanged live configuration, and changed configuration. Align the existing shared fixture's builder call with the pinned core API so this branch builds independently.
Fixes apache/shenyu#7454.
Validation: 14 tests in LoggingRabbitmqPluginDataHandlerTest and RabbitmqClientCacheTest, with Checkstyle and RAT. Broker-facing construction is mocked; no real RabbitMQ broker is required. Tested against core 2.7.2-SNAPSHOT at b46bf15c3a243e926994cb32c3f0a23eadc41adf.