Repository navigation
feat(eureka): externalize registry and starter with runtime parity checks - #32
yangjj-iso wants to merge 4 commits into
Conversation
|
Could a maintainer approve the current-head workflows for 0921f1a? Both are still action_required, so neither is a passing upstream validation result:
The paired core cutover apache/shenyu#7960 now has a confirmed deployment dependency on this receiver: its Spring Cloud IT Admin image reports that the eureka SPI provider is absent after the in-tree provider removal (https://github.com/apache/shenyu/actions/runs/42217134157/job/127891812451). Receiver CI and a compatible external-provider installation are required before that deployment can pass. The earlier local 13-checkpoint evidence is for the pinned source pair documented here, not a fresh result against current core. External publication, version alignment, coordinate ownership and rollback coordination remain explicit merge/release gates. |
|
Pushed be07c12 to validate the actual paired cutover (apache/shenyu 31d90ba, core 2.7.3-SNAPSHOT), instead of the pre-removal core revision. The selected core reactor is installed before classpath resolution. Fresh local results on OpenJDK 21/Linux: 7 unit/SPI/starter tests, 1 real Eureka lifecycle test, and all 13 Admin/gateway process checkpoints passed, including provider origins, bound-port registration, discovery/refresh, old-endpoint removal, graceful deregistration, restart and healthy-sibling preservation. The 163-module core reactor also built with Checkstyle/RAT. Reproducible source-pair and JAR-digest evidence is committed in e2e/results/linux-jdk21-current-core.json; the migration guide records the local compiler limitation. The new-head workflows still require maintainer approval:
Please approve these current runs. Local process validation does not establish passing Docker IT/E2E or artifact publication; those cutover gates remain open. |
Refs apache/shenyu#7596. Companion main cutover: apache/shenyu#7960.
Receive the Eureka registry and a dedicated gateway starter with the existing SPI/type/configuration contracts. The starter preserves bound-port registration and closes the provider on context shutdown. Package Jersey 3 transport, HK2 and JAX-RS privately so Bootstrap's existing Jersey providers cannot interfere; retained ShenYu API/SPI classes remain outside the shaded closure.
Real runtime checks exposed identity-only equality hiding upstream changes. Compare the published payload, emit UPDATED for same-endpoint changes, and remove the old URL before adding an IP/port replacement. Preserve polling-failure recovery. Add starter/SPI tests, a real-server Failsafe lane and a portable process harness using actual Admin, bootstrap, H2 and Eureka, with class-origin assertions and graceful shutdown on Windows/Linux.
Initial validation on Microsoft OpenJDK 17.0.18:
Current-core validation (2026-11-06): commit be07c12 pins the lifecycle workflow to the paired removal commit 31d90ba4022c3c49bbdd2aa507cb4e1f5fc8b87f and explicitly builds store 2.7.1-SNAPSHOT against core 2.7.3-SNAPSHOT. The selected core reactor is installed before runtime classpath resolution.
On OpenJDK 21.0.13/Linux, all 7 unit/SPI/starter tests, the real Eureka lifecycle test and all 13 Admin/gateway process checkpoints pass. The 163-module selected core reactor builds with Checkstyle/RAT, with tests compiled but skipped. Default Admin/bootstrap classpaths contain no Eureka provider or Netflix Eureka dependency before the external closure is added. The source pair, complete checkpoint list and provider JAR SHA-256 are recorded in e2e/results/linux-jdk21-current-core.json; docs record the local compiler workaround.
These are local process results and development coordinates, not a published compatibility matrix or an upstream workflow result. Docker image execution was not run. Workflow approval, compatible external publication and release/rollback coordination remain required before the main removal.