Skip to content

[SCB-1584] Implement the sidecar injector of kubernetes#85

Open
ChinX wants to merge 3 commits into
apache:masterfrom
ChinX:master
Open

[SCB-1584] Implement the sidecar injector of kubernetes#85
ChinX wants to merge 3 commits into
apache:masterfrom
ChinX:master

Conversation

@ChinX

@ChinX ChinX commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tianxiaoliang

Copy link
Copy Markdown
Contributor

inject is a verb which can not be used as pkg name

@tianxiaoliang

Copy link
Copy Markdown
Contributor

proxy-injector is not suitable for a pkg name

@tianxiaoliang

Copy link
Copy Markdown
Contributor

add doc plz

@ChinX

ChinX commented Nov 12, 2019

Copy link
Copy Markdown
Contributor Author

add doc plz

Ok, the status of the PR is "working in progress" and I will complete it in future commits.

@ChinX

ChinX commented Nov 12, 2019

Copy link
Copy Markdown
Contributor Author

inject is a verb which can not be used as pkg name

Ok, I will modify it.

@ChinX

ChinX commented Nov 12, 2019

Copy link
Copy Markdown
Contributor Author

proxy-injector is not suitable for a pkg name

Ok, I will modify it.

Comment thread proxy-injector/templates/servicecomb/servicecomb.go Outdated
Comment thread proxy-injector/inject/inject.go Outdated
Comment thread proxy-injector/inject/config.go Outdated
Comment thread proxy-injector/inject/config.go Outdated
@tianxiaoliang

Copy link
Copy Markdown
Contributor

doc plz

@WillemJiang

Copy link
Copy Markdown
Member

@ChinX Is there update on this PR?

@WillemJiang

Copy link
Copy Markdown
Member

Please use the JIRA to check the issue, otherwise it's impossible for us to generate the release note for JIRA.

Comment thread injector/cmd/start.go Outdated
Comment thread injector/templates/servicecomb/config.go Outdated
Comment thread injector/templates/servicecomb/config.go Outdated
Comment thread injector/templates/servicecomb/servicecomb.go Outdated
Comment thread injector/webhook/options.go Outdated
@tianxiaoliang

Copy link
Copy Markdown
Contributor

交付使用文档

@ChinX ChinX force-pushed the master branch 2 times, most recently from 0f5d24a to 192f616 Compare December 17, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants