Skip to content

[ISSUE #143] Loop reconcile console which can get the latest nameserver address#238

Open
drivebyer wants to merge 1 commit into
apache:masterfrom
ksmartdata:console-reconsile
Open

[ISSUE #143] Loop reconcile console which can get the latest nameserver address#238
drivebyer wants to merge 1 commit into
apache:masterfrom
ksmartdata:console-reconsile

Conversation

@drivebyer

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Loop reconcile console which can get the latest nameserver address

Brief changelog

Loop reconcile console which can get the latest nameserver address

Verifying this change

Loop reconcile console which can get the latest nameserver address

Please go through this checklist to help us incorporate your contribution quickly and easily.

Notice: It would be helpful if you could finish the following checklist (the last one is not necessary) before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check RBAC rights for Kubernetes roles.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run make docker-build to build docker image for operator, try your changes from Pod inside your Kubernetes cluster, not just locally. Also provide screenshots to show that the RocketMQ cluster is healthy after the changes.
  • Before committing your changes, remember to run make manifests to make sure the CRD files are updated.
  • Update documentation if necessary.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

…meserver address

Signed-off-by: yangw <wuyangmuc@gmail.com>

@caigy caigy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about accessing nameserver by service name?

@drivebyer

Copy link
Copy Markdown
Contributor Author

What about accessing nameserver by service name?

刚试了一下,确实可以 :)

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approved ✅

PR: #238 — Loop reconcile console which can get the latest nameserver address
Type: Enhancement (1 file, +10/-15)

Assessment

Refactors console controller to loop reconcile, ensuring the console always picks up the latest nameserver address. Reduces code by 5 lines while improving reliability.

Verdict

✅ Clean refactoring. Addresses a real operational need for dynamic nameserver discovery.


🤖 Automated review by oss-sentinel-ai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants