feat: added global labelselector feature for podmonitors#402
Merged
Conversation
Member
PR apache#592 migrated all *-podmonitor.yaml templates to use the shared pulsar.podMonitor helper in _monitor.tpl, which renders either a Prometheus PodMonitor or a VictoriaMetrics VMPodScrape resource. Adapted the customLabels feature to the new structure by injecting the labels in the shared helper instead of in each individual file, so they apply to both resource kinds and to all components covered by the helper (broker, bookkeeper, autorecovery, proxy, zookeeper, oxia-coordinator, oxia-server, standalone).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #401
Motivation
We are using grafana-agent, which uses label selector for podMonitors, so we need to be able to set custom labels on the podMonitors resources.
Modifications
Added a global variable to set custom labels for all podMonitors. If someone needs more granular label setting, it needs to be implemented for each service.
Verifying this change