escape html in FileAndResourceDirectives - #1191
Merged
Merged
Conversation
He-Pin
reviewed
Jul 30, 2026
He-Pin
left a comment
He-Pin
left a comment
Member
There was a problem hiding this comment.
Overall LGTM — the escaping logic is correct and covers all user-controlled insertion points. One small suggestion inline.
| val escapedPath = escapeHtml(path) | ||
| sb.append(html(0)).append(escapedPath).append(html(1)).append(escapedPath).append(html(2)) | ||
| if (!isRoot) { | ||
| val secondToLastSlash = path.lastIndexOf('/', path.lastIndexOf('/', path.length - 1) - 1) |
Member
There was a problem hiding this comment.
Nit: escapeHtml(path) here is called once per file/directory entry, but you already computed escapedPath a few lines above. Could just reuse it:
sb.append("<a href=\"").append(escapedPath).append(escapedName).append("\">").append(escapedName).append("</a>")Avoids redundant escaping in directories with many entries.
Member
Author
There was a problem hiding this comment.
escapedPath is already handled this way
He-Pin
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added escapeHtml methods to the DirectoryListing object that escape the five HTML special characters (&, <, >, ", '). Applied to all user-controlled strings in the directory listing HTML:
<title>and<h1>tagsPretty unlikely but there is a theoretical chance that filenames could have problematic XSS type names.
Claude AI thinks that we should harden the code as a result.