Repository navigation
Prepare RC: write generated Maven settings outside the repo - #3763
Merged
Merged
Conversation
.release-settings.xml was created in the repo root before mvn deploy
-Papache-release ran, which activates the RAT check. RAT flagged the
generated file for a missing ASF license header and failed the deploy.
Use mktemp under RUNNER_TEMP (with TMPDIR / /tmp fallbacks) so the file
lives outside the tree RAT scans, and guard the EXIT trap with
${settings_file:-} in case the script exits before the variable is set.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Fokko
approved these changes
Sep 3, 2026
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Contributor
|
Thanks again @RussellSpitzer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Before we were making a temporary .release-settings.xml in the working directory. This caused RAT to fail since the temp file was not licensed correctly.
Now we use mktemp under RUNNER_TEMP (with TMPDIR / /tmp fallbacks) so the file lives outside the tree RAT scans, and guard the EXIT trap with ${settings_file:-} in case the script exits before the variable is set.
What changes are included in this PR?
Changes the position of the temporary file
Are these changes tested?
Only locally, made sure the file writes outside of the working directory
Are there any user-facing changes?
No