Repository navigation
Fix/prepare rc self ci check - #3762
Merged
Merged
Conversation
check_github_checks_passed queried the check-runs API and counted the currently-executing "Prepare Release Candidate" job as an incomplete check, so the step always failed with dry_run=false. Switch to the workflow-runs API and filter out any workflow whose path starts with .github/workflows/release-, so this run's self-reference and any historical release-process attempts on the same commit are ignored while real code CI (ci-hadoop3, vector-plugins, ci-release-scripts) is still enforced. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Rewrites the "still running" and "failed conclusion" tests around the workflow-runs mock shape, and adds three tests covering the release-*.yml filter: in-progress self-reference is ignored, historical failed release runs on the same commit are ignored, and real CI failures are still detected when release workflows are mixed in. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Drop the two separate "ignores release-*.yml" tests and keep one test that exercises both the filter and the failure detection: a release workflow in-progress alongside a failed CI workflow. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Fokko
approved these changes
Sep 3, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
The LLM approves 👍 Thanks @RussellSpitzer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
The "Prepare Release" job now ignores github actions on a commit that are related to the release. Previously we would check that no actions were running (to make sure CI had finished) but by running the release job we started a new action on that commit. To fix this we just ignore all jobs that start with release-*.
Are these changes tested?
New Bats tests checking this situation
Are there any user-facing changes?
No