Repository navigation
fix(global-index): support external path for global index checkpoints - #473
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #382
Global index checkpoints currently use the table's index directory even
when
global-index.external-pathis configured.This change makes checkpoint writes, recovery, and cleanup use
<global-index.external-path>/checkpoint/<task_id>when configured.Without an external path, checkpoints remain under
<table_path>/index/checkpoint/<task_id>.Task cleanup resolves the external path from table schema options and
caller overrides, preserving other tasks' checkpoints and completed
index files.
Tests
src/paimon/core/global_index/global_index_file_manager_test.cpp
src/paimon/core/utils/file_store_path_factory_test.cpp
test/inte/global_index_test.cpp
Documentation
uniqueness across tables sharing an external index directory.
reference into the user guide.