Skip to content

refactor(blob-view): resolve blob view dependencies through catalog context - #455

Merged
lxy-9602 merged 3 commits into
apache:mainfrom
lszskye:blob_view_rm
Oct 23, 2026
Merged

lxy-9602 merged 3 commits into
apache:mainfrom
lszskye:blob_view_rm

Conversation

@lszskye

@lszskye lszskye commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Purpose

Blob view resolution previously used a temporary upstream warehouse override
or inferred the warehouse from the table's storage path. This could select
the wrong warehouse for REST catalogs.

  • Remove blob-view-upstream-warehouse and its parsing, accessor, and usages.
  • Build dependency contexts using the attached catalog's warehouse, retaining
    path-based warehouse inference when no catalog is attached.
  • Merge dependency options with explicit read options taking precedence over
    catalog options, and catalog options over table options.
  • Generate X-Paimon-Read-Via only when the merged metastore is REST, a table
    identifier is available, and the merged options contain no existing header.
  • Keep catalog settings out of ReadContextBuilder::Finish() so dependency
    catalog options do not override the upstream reader's own table settings.

Tests

  • Cover option precedence, final-metastore header generation, existing-header
    preservation, branch identifiers, and filesystem scheme propagation.
  • Verify read options override table options through TableRead::Create().
  • Update blob integration tests to resolve upstream tables without the removed
    warehouse override.

API and Format

  • Breaking API/configuration change: remove
    Options::BLOB_VIEW_UPSTREAM_WAREHOUSE and its warehouse override behavior.

@lszskye
lszskye requested a review from lucasfang October 22, 2026 08:25
lxy-9602
lxy-9602 previously approved these changes Oct 22, 2026

@lxy-9602 lxy-9602 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lxy-9602 lxy-9602 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lxy-9602
lxy-9602 merged commit 758d225 into apache:main Oct 23, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants