Repository navigation
Conversation
rich7420
marked this pull request as ready for review
October 8, 2026 15:18
Russole
self-requested a review
October 9, 2026 12:50
chihsuan
approved these changes
Oct 10, 2026
| handler = new DeleteBlocksCommandHandler( | ||
| container, configuration, dnConf, ""); | ||
| // Stop the worker so that handle() can fill the queue without commands being consumed. | ||
| handler.stop(); |
Contributor
There was a problem hiding this comment.
Just an observation: I found it interesting that handle() still queues after stop(). 🙂 This looks fine given the production shutdown flow, but if production later rejects commands after shutdown, we’ll need to adjust the test setup.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! Agreed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Stop the background worker before enqueueing commands in the queue-full test. The worker could otherwise consume commands while the test fills the queue, changing their status or preventing the queue from reaching its limit.
The existing PENDING, FAILED and empty-ACK assertions are preserved, with an additional assertion that five commands remain queued. No production code changes.
What is the link to the Apache JIRA?
https://issues.apache.org/jira/browse/HDDS-10711
How was this patch tested?
testClientWithLocalLeaseEnabled(local-lease success count stayed at zero). This is a separate OM test; its root cause is not yet confirmed. Other checks passed. The local-lease failure remains under investigation.