Skip to content

HDDS-16657. Reject lifecycle Transition actions in PutBucketLifecycleConfiguration - #11430

Merged
chungen0126 merged 1 commit into
apache:masterfrom
priyeshkaratha:HDDS-16657
Oct 7, 2026
Merged

chungen0126 merged 1 commit into
apache:masterfrom
priyeshkaratha:HDDS-16657

Conversation

@priyeshkaratha

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Currently, PutBucketLifecycleConfiguration does not support the Transition field. If a request includes a Transition rule, the API silently ignores it and returns a 200 success response.
This change updates the behavior to reject requests that include a Transition rule, rather than silently dropping the unsupported field and returning a successful response.

What is the link to the Apache JIRA

HDDS-16657

How was this patch tested?

Tested using newly added testcase.

@github-actions github-actions Bot added the s3 S3 Gateway label Oct 7, 2026
@priyeshkaratha
priyeshkaratha marked this pull request as ready for review October 7, 2026 08:17
@priyeshkaratha priyeshkaratha added the s3-lifecycle HDDS-8342 label Oct 7, 2026
@XmlAccessorType(XmlAccessType.FIELD)
@XmlRootElement(name = "Transition")
public static class Transition {
@XmlElement(name = "Days")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could we omit Days and Date and their accessors? Transition actions are always rejected, so only StorageClass is needed for the error message.

@rich7420 rich7420 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

@chungen0126 chungen0126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@chungen0126
chungen0126 merged commit c99d291 into apache:master Oct 7, 2026
60 of 61 checks passed
@chungen0126

Copy link
Copy Markdown
Contributor

Merged. Thanks @priyeshkaratha for working on this, @rich7420 for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s3-lifecycle HDDS-8342 s3 S3 Gateway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants