Repository navigation
HDDS-15681. Switch to io.github.ascopes:protobuf-maven-plugin - #11429
Merged
Merged
Conversation
github-actions
Bot
added
documentation
rich7420
reviewed
Oct 7, 2026
| <goal>test-compile-custom</goal> | ||
| <goal>generate</goal> | ||
| </goals> | ||
| <configuration> |
Contributor
There was a problem hiding this comment.
Please set <incrementalCompilation>false</incrementalCompilation> for compile-proto-for-ratis here and in interface-server. A second build without clean skips protoc but runs the shading replacement again, producing org.apache.ratis.thirdparty.org.apache.ratis.thirdparty... and failing compilation. I reproduced this; disabling incremental compilation fixes the failure.
Contributor
|
@adoroszlai thanks for the update |
chungen0126
approved these changes
Oct 7, 2026
chungen0126
left a comment
chungen0126
left a comment
Contributor
There was a problem hiding this comment.
+1 LGTM
We also need a follow-up PR to update the Ozone documentation:
https://ozone.apache.org/docs/next/developer-guide/build/maven
Contributor
|
Thanks @adoroszlai for the patch. Thanks @rich7420 @chungen0126 for the reviews. |
Contributor
Filed HDDS-16777 to update doc. |
Contributor
Author
|
Thanks @chungen0126, @rich7420, @smengcl for the review. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Oct 8, 2026
* master: (23 commits) HDDS-15951. Reduce ofs getFileChecksum to a single OM RPC (apache#11380) HDDS-16746. Local Stream onCommand should drain buffers before commit PutBlock (apache#11427) HDDS-16781. Fix intermittent ReadChunk count mismatch in TestKeyInputStream (apache#11443) HDDS-16779. FSO rename of a file to itself should be a no-op (apache#11440) HDDS-16724. Add support for missing S3 apis to STS (apache#11413) HDDS-16620. Expose BlockReadCursor as an iterator of streaming ReadBlock ranges (apache#11442) HDDS-16624. Improve AbortIncompleteMultipartUpload lifecycle validation error message (apache#11344) HDDS-16367. Update threat model with information about internal protocols (apache#11185) HDDS-16304. Convert RpcMetrics latency counters to lock-free ConcurrentMutableStat (apache#11425) HDDS-15681. Switch to io.github.ascopes:protobuf-maven-plugin (apache#11429) HDDS-16258. Refactor streaming block reads and fix checksum verification for variable-sized chunks (apache#11302) HDDS-16598. Fix intermittent failure in TestContainerStateMachine (apache#11319) HDDS-15802. Add integration tests for per-volume push replication (apache#11146) HDDS-16657. Reject lifecycle Transition actions in PutBucketLifecycleConfiguration (apache#11430) HDDS-16714. Split kubernetes check by environment (apache#11406) HDDS-16752. Bump guava to 33.7.2-jre (apache#11433) HDDS-16581. Bump ozone-runner to 20260922-1 (apache#11431) HDDS-16611. Use MutableGaugeLong for total count metrics in OMMetrics (apache#11410) HDDS-16738. Let dependabot ignore jetty minor version upgrades (apache#11422) HDDS-16683. Upgrade Jetty from 12.0.38 to 12.1.14 (apache#11424) ... Conflicts: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneManagerVersion.java hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueHandler.java hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/TestReplicationManager.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestWithFSO.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Switch
protobuf-maven-pluginfrom org.xolstice.maven.plugins to io.github.ascopes, since the former is no longer maintained and recommends the latter.The new plugin requires Java 17 at build time. It also requires newer Maven (3.9.6+).
https://issues.apache.org/jira/browse/HDDS-15681
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/37510970916