Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
InnerNodeImpl#getLeafused a raw string-prefix comparison to determinewhether an excluded scope belonged to a child subtree. As a result, an
excluded path under
/r10was also treated as belonging under/r1,reducing both subtrees' available leaf counts and causing
chooseRandomto return
nulleven when an eligible node existed.The change uses
Node#isAncestor(String)for topology-aware pathcomparison. This preserves exact-node and genuine-descendant exclusions
while respecting path-component boundaries.
A regression test creates nodes under
/r1and/r10, excludes the nodeunder
/r10, and verifies that the node under/r1is selected.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16631
How was this patch tested?
mvn -ntp -pl :hdds-server-framework test '-Dtest=TestNetworkTopologyImpl#testChooseRandomWithExcludedScopePrefix' -DskipShade -DskipRecon -DskipDocsmvn -ntp -pl :hdds-server-framework clean test -DskipShade -DskipRecon -DskipDocs(
646tests,0failures,0errors,1skipped)./hadoop-ozone/dev-support/checks/checkstyle.shbuild-branchworkflow:https://github.com/adwetojha/ozone/actions/runs/37128788136