Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Deleting a RECOVERING container removes it from the container set but leaves its recovery deadline in
recoveringContainerMapuntil the background scrub removes it.Remove the recovering entry during deletion under the existing container write lock, matching the cleanup performed when closing a container. Add a test that force-deletes a RECOVERING container and checks both maps.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16460
How was this patch tested?
ae281be314):TestKeyValueHandlerandTestContainerSetpassed, 57 tests total. Without the production fix,testDeleteRecoveringContainerfails because the recovery entry remains.