Conversation
Signed-off-by: F64116045 <f64116045@gs.ncku.edu.tw>
Signed-off-by: F64116045 <f64116045@gs.ncku.edu.tw>
Contributor
Author
|
The original |
F64116045
marked this pull request as ready for review
October 3, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The ceph/s3-tests
test_object_set_get_unicode_metadataexposed that S3 Gateway does not handle non-ASCII user metadata correctly.Investigation showed that S3 uses RFC 2047 for non-ASCII
x-amz-meta-*values. Ozone currently stores encoded values as ordinary text and does not encode them when returning response headers.This patch decodes RFC 2047 Q/B values before storing metadata and encodes non-ASCII values in GET and HEAD responses.
References:
What is the link to the Apache JIRA?
https://issues.apache.org/jira/browse/HDDS-16672
How was this patch tested?
CI: https://github.com/F64116045/ozone/actions/runs/37118609154
Uploaded an object with this RFC 2047 encoded
cafémetadata:x-amz-meta-meta1: =?UTF-8?B?Y2Fmw6k=?=The same request was tested against Ozone before and after this patch, and against S3.
B and Q are two RFC 2047 representations of the same
cafévalue.cafécafécafécafé