Conversation
rich7420
marked this pull request as draft
October 2, 2026 15:01
rich7420
marked this pull request as ready for review
October 3, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
OzoneManagerVersion.S3_DERIVED_KEYand gate derived-key requests on the negotiated OM version for key and multipart writes.In secure mode, S3 Gateway rejects signed chunk uploads against older OMs with
NotImplementedbefore opening the key, instead of failing later withInternalErrorwhen the derived key is missing. A missing key from a supporting OM remains an error. UploadPart failures also update the failure metrics and audit log.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16358
How was this patch tested?
Added coverage in
TestRpcClient,TestEndpointBase,TestObjectPut, andTestPartUploadfor OM version gating and signed upload rejection.33ef9fdd33with JDK 21: 234 tests passed across these four classes; checkstyle passed.RpcClientmakes 8 of the 48 version-gating cases fail. All 48 pass with the fix.33ef9fdd33:integration (client)failed inTestFailureHandlingByClient.testContainerExclusionWithClosedContainerException, at the existing pre-close assertion inOzoneTestHelper.waitForContainerClose.27f4208878): fork CI, TestRpcClient 10×10, and S3 endpoint tests 10×10.Generated-by: Codex (GPT-6)