Repository navigation
HDDS-16181. Add container balancer recommend CLI command to suggest config for each profile - #11342
Open
sravani-revuri wants to merge 6 commits into
Open
sravani-revuri wants to merge 6 commits into
sravani-revuri wants to merge 6 commits into
Conversation
…onfig values for slow/medium/fast profiles
sravani-revuri
marked this pull request as ready for review
September 28, 2026 04:25
Contributor
Author
|
@ashishkumar50, @rakeshadr, @sreejasahithi could you please review these changes? |
sreejasahithi
requested review from
ashishkumar50,
rakeshadr and
sreejasahithi
September 28, 2026 04:28
sarvekshayr
reviewed
Sep 28, 2026
sarvekshayr
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sravani-revuri for working on this.
What is the difference between container balancer recommend and estimate commands? recommend also prints estimate output.
Also, resolve the merge conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add ozone admin containerbalancer recommend command
The command should:
Fetch live datanode usage from SCM (via the existing getDatanodeUsageInfo RPC)
Read local Ozone configuration for global defaults (threshold, timeouts, move limits etc.)
Analyze the cluster using existing ContainerBalancerClusterAnalyzer / ContainerBalancerClusterSnapshot (HDDS-16173)
For each profile (SLOW, MEDIUM, FAST), produce:
Recommended configuration parameters with a short rationale
Time/iteration estimates by reusing ContainerBalancerAdvisor.estimateDryRun() (HDDS-16179)
Each recommended values should be validated first.
No --profile, config overrides, or interactive mode on this command
If the user wants custom inputs or refined estimates, they use dry-run instead.
But the command should allow the user to provide include/exclude datanodes and threshold values.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16181
How was this patch tested?
written test and manual test.
all profiles recommend + estimate :
threshold recommend + estimate
include all matches with estimate --all
exclude recommend + estimate
no imabalence recommend command: