examples/rust: Fix hello_rust_cargo CMake settings#3494
Merged
Conversation
Use the hello_rust_cargo-specific Kconfig symbols for the built-in application stack size and priority. Previously, CMake referenced the generic hello example symbols, so the configured hello_rust_cargo stack size could be ignored. Signed-off-by: Shoji Tokunaga <toku@mac.com>
Member
|
@no1wudi Could you help to review this PR? Thanks :-) |
xiaoxiang781216
approved these changes
May 22, 2026
no1wudi
approved these changes
May 22, 2026
lupyuen
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/rust: Fix CMake stack and priority config names
Summary
This fixes the CMake configuration for the
hello_rust_cargoexample.The CMake file was using
CONFIG_EXAMPLES_HELLO_STACKSIZEandCONFIG_EXAMPLES_HELLO_PRIORITY, but this application is configured by theCONFIG_EXAMPLES_HELLO_RUST_CARGO_*symbols. The Makefile already uses theRust Cargo-specific symbols.
With this change, the CMake built-in application registration uses the
configured Rust Cargo example stack size and priority, matching the Makefile
behavior.
Impact
When running on a target, it prevents "
malloc()and other functions failing and triggering assertions."Testing
I confirm that changes are verified on local setup and works as intended:
Configuration:
Build:
Testing logs before change:
hello_rust_cargomay sometimes cause assertion failures.Testing logs after change: