Repository navigation
Take the JUnit version from the parent's versions.junit - #648
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
The parent already imports the JUnit BOM; this line only sets the version, as the other Maven 4 lines do.
slachiewicz
added
dependencies
slachiewicz
marked this pull request as ready for review
November 3, 2026 20:25
gnodet-bot
approved these changes
Nov 3, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. Removing the explicit junit-bom import and unifying under versions.junit is the correct approach. The versions.junit5=${versions.junit} alias correctly bridges maven-parent 50 (which reads versions.junit5) so the 6.1.3 override flows through without any functional gap.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JUnit version comes from the parent's
versions.junit(6.1.3), as on the other Maven 4 lines, instead of a second import of the JUnit BOM with its ownjunitVersion.versions.junit5points at it because maven-parent 50 still reads that name; apache/maven-parent#633 renames it.Verified:
mvn verifywith Maven 4.0.0-rc-7 → 16 tests pass on junit-jupiter 6.1.3.