Never index checksum or signature files as artifacts - #797
Merged
Merged
Conversation
DefaultArtifactContextProducer now also skips any file the GavCalculator parses as a hash or signature, so the isIndexable suffix list can no longer fall behind the calculator (the cause of #692). M2ArtifactRecognizer recognizes .sha256 and .sha512 checksums too.
slachiewicz
marked this pull request as ready for review
September 26, 2026 10:53
slachiewicz
added a commit
that referenced
this pull request
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #693.
DefaultArtifactContextProduceralso skips any file that theGavCalculatorparses as a hash or signature, so a checksum type added to the calculator can no longer be indexed as the main artifact whileisIndexablestill lacks its suffix.M2ArtifactRecognizer.isChecksum,isPomandisMetadatanow recognize.sha256and.sha512as well as.sha1and.md5.Verified: both new tests fail without their fix and pass with it.