refactor(desktop): centralize auxiliary window lifecycle - #5507
Open
colaforniaw wants to merge 3 commits into
Open
colaforniaw wants to merge 3 commits into
colaforniaw wants to merge 3 commits into
Conversation
colaforniaw
force-pushed
the
refactor/desktop-auxiliary-window-registry
branch
5 times, most recently
from
September 20, 2026 02:54
2dbab07 to
254c8cb
Compare
colaforniaw
force-pushed
the
refactor/desktop-auxiliary-window-registry
branch
2 times, most recently
from
September 20, 2026 06:29
e39b2a8 to
6a6f70f
Compare
colaforniaw
marked this pull request as ready for review
September 20, 2026 06:57
added 2 commits
September 21, 2026 15:01
colaforniaw
force-pushed
the
refactor/desktop-auxiliary-window-registry
branch
from
September 21, 2026 07:06
6a6f70f to
f5b253d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five auxiliary window types each implemented parts of the same hidden creation, reveal, focus, theme, and guarded teardown lifecycle. This change declares the permission overlay, startup progress, WorkHub, cursor overlay, and PiP windows in one registry and routes those operations through it.
The final registry is deliberately narrow: declarations,
create/show/focus/destroy, theme following, and the auxiliary renderer-to-parent map required by browser presentation. Run reveal mode flows fromstartup-context.ts, preserving hidden and inactive E2E behavior. Browser IPC owns session selection and passes its parent resolver into the BrowserView factory; the main-window controller no longer owns auxiliary renderer or parent-resolution state.The ablation pass removed batch teardown and keep-alive policy execution, the active/inactive reveal branch, parent validation, public interface boilerplate, renderer forwarding methods, and stored session-resolver callbacks. Production code is now
+218/-99(net+119); the remaining net+78is focused test coverage.Fixes #5379
Verification
npm run lintpassed (3,745 files);npm run format:checkpassed (2,197 files)npm run typecheckpassed across all workspaces after rebuilding Desktop's workspace dependenciesnpm --workspace @maka/desktop run build:mainandgit diff --checkpassedAI use
Select exactly one:
Tool(s) and scope: Codex implemented, simplified, reviewed, and verified the auxiliary window registry refactor.
Checklist
Does this PR entail a change in behavior?