Repository navigation
feat(bitbucket): add Data Center review state writes - #1746
Open
KatalKavya96 wants to merge 1 commit into
Open
KatalKavya96 wants to merge 1 commit into
KatalKavya96 wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @potiuk, This is the next focused #606 Data Center parity follow-up. It enables the existing standalone review-state commands on Data Center through the participant-status API:
The implementation keeps the existing backend-neutral CLI and normalizers, adds API + CLI coverage for all four operations, and avoids the deprecated approval-specific endpoints. The combined Refs #606 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr approvepr unapprovepr request-changespr remove-request-changesType of change
.claude/skills/<name>/)tools/<system>/*.md)tools/*/withpyproject.toml)Implementation
Bitbucket Data Center review state is updated through the pull-request participant resource for the authenticated user.
The command mappings are:
pr approve→APPROVEDpr unapprove→UNAPPROVEDpr request-changes→NEEDS_WORKpr remove-request-changes→UNAPPROVEDThe bridge first resolves the authenticated Data Center user's slug, then updates that user's participant state on the target pull request.
This avoids the deprecated approval-specific endpoints and keeps the existing normalized approval/change-request output contracts unchanged across Cloud and Data Center.
Test plan
tools/bitbucket/tests/test_bitbucket.pysuite passesgit diff --checkpassesScope
This PR adds standalone Data Center review-state mutations only.
The combined:
pr review <id> --verdict {comment,approve,request-changes} --body-file <path>path remains Cloud-only because Data Center review-body + verdict semantics are a separate follow-up.
Data Center decline/reject and merge writes also remain separate follow-ups.
Refs #606