Repository navigation
feat(code-review): default to a maintainer fixup for small, mechanical findings - #1743
Merged
Merged
Conversation
…l findings When every approval gate holds and the only findings left are minor or nit ones with a mechanical fix, sending the PR back for another round costs the contributor a cycle for changes the maintainer could make in a minute. The disposition step now offers FIXUP as the default in that case: commit exactly those changes to the PR head on the maintainer's confirmation, wait for CI, and approve with a body that lists what the fixup changed. - `disposition` takes `--head-pushable` and a per-finding `fixup` line, and returns `fixup`, `default` and a `FIXUP` override when eligible. - A major or blocking finding is never fixed up; no gate is skipped (CI, threads, standing change requests, open questions, conflicts). - New classifications/disposition-fixup.md describes the flow; Step 6 of review-flow.md offers `[F]ixup`, and scope.md carves out this one confirmed path from "never edits the contributor's branch". - Merging stays a separate, confirmed action. Generated-by: Claude Opus 5
potiuk
added
family:pr-management
github-actions
Bot
added
family:tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When every approval gate holds and the only findings left are
minor/nitones with a mechanical fix, sending the PR back costs the contributor a round trip for changes the maintainer could make in a minute.pr-management-code-reviewnow offers[F]ixupas the default in that case: commit exactly those changes to the PR head on the maintainer's confirmation, wait for CI, then approve with a body that lists what the fixup changed.pr-management code-review dispositiontakes--head-pushableand a per-findingfixupline.When eligible, it returns
fixup.changes,default: "FIXUP"and aFIXUPoverride.majororblockingfinding is never fixed up.No approval gate is skipped: real CI green, no unresolved thread, no standing change request, no open maintainer question, and a branch that merges cleanly.
classifications/disposition-fixup.mddescribes the flow.Step 6 of
review-flow.mdoffers[F]ixup, and Step 4's finding shape gainsfixup.scope.mdcarves this single confirmed path out of "never edits the contributor's branch".specs/pr-management-family.mdare updated.Tests: 8 new cases in
tools/pr-management/tests/code_review/test_decisions.pycover eligibility, push access, non-mechanical findings, majors, every approval gate, and the nit-onlyAPPROVE.The code-review suite and
prekpass.SKILL.mdis unchanged, so no token restamp is needed.Exercised by hand on #1728 before it was written up.
Generative AI: drafted with Claude Code (Claude Opus 5), reviewed by the author.
🤖 Generated with Claude Code