Repository navigation
feat(setup): add repo-health family first-run welcome guide - #1724
Conversation
|
Hi @potiuk, I've completed the Repository Health family welcome guide for #1660, following the established pattern from the recently merged welcome-guide PRs. It covers all seven skills, their configuration requirements, example workflows, and safety boundaries. I've also included the standardized README integration, first-run evaluation fixture, and regression tests. All repository-wide checks passed locally with prek run --all-files. |
- Renumber the first-run eval case to case-19, after the case-16..18 floor cases that landed with apache#1673. - Say that audit-finding-fix asks before every write and commit, not only before the draft PR. - Give the license audit its own prompt in the flow and drop the sentence that repeated it. - Name what a "make it yours" request becomes, as the other family guides do. Generated-by: Claude Opus 5
9a9b905 to
9fbe65b
Compare
potiuk
left a comment
There was a problem hiding this comment.
Thanks for the repo-health guide. It fits the existing family-guide pattern, its config claims match the skills' requires_config frontmatter, and the new test covers all seven skills' family membership and the general → family → general sequencing.
#1673 merged after this was opened and edits the same eval counts and the case-9 report, so rather than send it back I rebased the branch onto main and pushed two commits:
- your commit, rebased, with the counts taken from
main(139 cases total, 19 forpreflight-floor, and your repo-health description appended tomain's row) andcase-9re-rendered withtools/dev/render-preflight-fixtures.py; - a fixup (
9fbe65bd):- the eval case is renumbered to
case-19-repo-health-first-run, aftermain'scase-16–case-18; guides/repo-health.mdnow saysaudit-finding-fixasks before every write and commit, not only before the draft PR;- the license audit gets its own prompt in the flow, and the sentence that repeated it is gone;
- "make it yours" now names what a request becomes, as the other family guides do.
- the eval case is renumbered to
One note for later: once the setup and release-management guides land, every family will have a guide, and the "family without a guide" tests in test_welcome.py will need a synthetic guide-less family instead of rc-cut.
Thanks!
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
Contributing guide.
- Renumber the first-run eval case to case-20, after the floor cases from apache#1673 and the repo-health case from apache#1724. - Present isolated-setup-update as the read-only drift check it is, and stop reusing the section heading's emoji for that step. - Name what a "make it yours" request becomes, as the other family guides do. - One sentence per line where the guide wrapped mid-sentence. Generated-by: Claude Opus 5
* feat(setup): add setup family first-run welcome guide * Apply review fixups for the setup welcome guide - Renumber the first-run eval case to case-20, after the floor cases from #1673 and the repo-health case from #1724. - Present isolated-setup-update as the read-only drift check it is, and stop reusing the section heading's emoji for that step. - Name what a "make it yours" request becomes, as the other family guides do. - One sentence per line where the guide wrapped mid-sentence. Generated-by: Claude Opus 5 --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Summary
audit-finding-fixfollows an explicit approval process for changes and draft PR creation.docs/repo-health/README.mdusing the standardized family README layout, add regression tests and a new first-run evaluation fixture, regenerate affected welcome reports, and update evaluation counts.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
render-preflight-fixtures.py --checkpassed with no fixture drift.case-16-repo-health-first-runusing the actualci-runner-auditsurface hash.git diff --cached --checkpassed.prek.RFC-AI-0004 compliance
Linked issues
Closes #1660
Refs #1654
Notes for reviewers (optional)
audit-finding-fixci-runner-auditdependency-auditdependency-license-auditflaky-test-triagelicense-compliance-auditworkflow-security-auditcase-16-repo-health-first-runwithsurface_hash: sha256:c6da72e64ac4808dand updates the setup evaluation count from 135 to 136.OTHER_SKILLtest helper fromci-runner-audittorc-cut, since Repository Health now has a welcome guide. This preserves coverage for families without welcome guides. The helper will need another adjustment when the Release Management guide is introduced.AI assistance disclosure: AI assistance was used for repository analysis, implementation drafting, and review. Changes were applied and validated locally by the contributor.